Examine impact of holder_type restriction

[iangow]

@sapyung

I will put this restriction back in and run the whole paper again to see what impact it has.

holder_type IN ('Hedge Fund Company', 'Investment Adviser')

[iangow]

@sapyung Each activist has its own holder type. The old code did not pick this up. Now I think we'd want to include any case where ('Hedge Fund Company' %in% holder_types | 'Investment Adviser' %in% holder_types).

[sapyung]

There was no issue with holder_type

dissident_data <-
    dissidents %>%
    group_by(campaign_id) %>%
    summarize(hedge_fund = bool_or(holder_type %in% c("Hedge Fund Company", "Investment Adviser")),
              sharkwatch50 = bool_or(sharkwatch50 == "Yes"),
              holder_types = sql("array_agg(holder_type ORDER BY holder_type)"),
              dissidents = sql("array_agg(dissident ORDER BY dissident)"))

I looked up if any Hedge Fund Company or Investment Adviser shows up as holder_type for dissident_data %>% filter(!hedge_fund) and there was none.

[iangow]

Does the code run fine?

On 13 Dec 2018, at 9:54 am, Sa-Pyung Sean Shin notifications@github.com wrote:

There was no issue with holder_type

dissident_data <- dissidents %>% group_by(campaign_id) %>% summarize(hedge_fund = bool_or(holder_type %in% c("Hedge Fund Company", "Investment Adviser")), sharkwatch50 = bool_or(sharkwatch50 == "Yes"), holder_types = sql("array_agg(holder_type ORDER BY holder_type)"), dissidents = sql("array_agg(dissident ORDER BY dissident)")) I looked up if any Hedge Fund Company or Investment Adviser shows up as holder_type for dissident_data %>% filter(!hedge_fund) and there was none.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[sapyung]

@iangow I have no problem running create_activism_sample.R.