iangow / se_features

Linguistic features derived from StreetEvents
1 stars 3 forks source link

Review NER code changes made by Yvonne #19

Closed Yvonne-Han closed 4 years ago

Yvonne-Han commented 4 years ago

@iangow I've been playing with your NER tagging code these days and trying to get it running so that Maliha can use the output data for her thesis. As you can see from the commit history, I made some changes to your code but I am not 100% sure (some of your code I guess is project-specific for your non-answer paper?). So here's a summary of what I've changed and boxes for you to tick (important things in bold):

I don't really understand what is going on here so it is likely that I am making a mistake here. If I include the SQL in the code, it seems to be producing a lot of NA entries and the number of NA increases as the code runs longer. So I decided to comment it out and it seems to work better (not sure). I've added a comment here too so you can cross-reference it.

iangow commented 4 years ago

No need to upload the NER files to GitHub, as they are version-controlled elsewhere by someone else and we can easily use "a little wget magic" (see here) to get the necessary file.

Yvonne-Han commented 4 years ago

The NER code should be okay now so I'm closing this one.