search

iangreenleaf / githubot

Github API access, tailored for Hubot
MIT License
106 stars 37 forks source link

Support Oauth token #1

Closed iangreenleaf closed 12 years ago

iangreenleaf commented 12 years ago

See github/hubot-scripts#309.

rcs commented 12 years ago

I implemented something similar..

https://github.com/github/hubot-scripts/blob/214b0f06e2f17ba6934c8bfc91bafe8463f789fe/src/scripts/octospy.coffee#L81

iangreenleaf commented 12 years ago

Cool, thanks for sharing. I actually titled this ticket completely wrong - githubot already supports the oauth token. What I was contemplating was supporting basic authentication as an alternative. I even implemented the changes (and pushed them to a branch), but then I started doubting that there was any demonstrated need for it. So unless I get requests for it, I'm probably scrapping this feature.