reserved identifier violation

ianh / owl

A parser generator for visibly pushdown languages.

MIT License

746 stars 21 forks source link

reserved identifier violation #15

Closed elfring closed 5 years ago

elfring commented 5 years ago

I would like to point out that identifiers like “_AUTOMATON_H_” and “_TERMINAL_H_” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

ianh commented 5 years ago

That's true. I'm not sure what to do about names like _2_BUILD_H_ though -- 2_BUILD_H isn't going to work.

elfring commented 5 years ago

I suggest to use another prefix for these include guards.

ianh commented 5 years ago

Should be resolved in 7ada0bd. Thanks for the report!

elfring commented 5 years ago

Thanks for your adjustment of affected include guards.