search

ianhinder / Kranc

A Mathematica package for generating code for solving time dependent partial differential equations
http://kranccode.org
GNU General Public License v2.0
28 stars 10 forks source link

Do not use quotes around real-valued parameter ranges in param.ccl #109

Closed ianhinder closed 7 years ago

ianhinder commented 9 years ago

Kranc currently adds quotes around parameter ranges in param.ccl files for parameters which are not strings. It shouldn't.

See also https://trac.einsteintoolkit.org/ticket/1595.

rhaas80 commented 7 years ago

This was fixed in 1e30463 "Correct formatting of parameter value ranges" Wed Jun 3 16:02:07 2015 -0400 I believe. The piraha parser would fail to accept such a quoted range as far as I know as well.

stevenrbrandt commented 7 years ago

Piraha will accept it, but will generate a warning.