ianhinder / Kranc

A Mathematica package for generating code for solving time dependent partial differential equations
http://kranccode.org
GNU General Public License v2.0
29 stars 10 forks source link

Move McLachlan-specific code out of Kranc #53

Open barrywardell opened 12 years ago

barrywardell commented 12 years ago

There is come code in CalculationFunction which should be moved out of Kranc and into McLachlan or other evolution thorns which require it. There are two specific cases I am aware of:

Not only do these not belong in Kranc, but they can also lead to confusing bugs. For example, in McLachlan it is possible to use the stress tensor in the RHS of a calculation unconditionally, but it can only be used in the LHS if the stress_energy_storage parameter is set. Trying to use it in the LHS without setting the parameter doesn't give any warning or error until the sefault when running the simulation.

barrywardell commented 12 years ago

This is related to/a duplicate of issue #3.