search

ianjones / moodle-assignsubmission_comparativejudgement

GNU General Public License v3.0
3 stars 3 forks source link

Bug with "comparison comments" and sorting #31

Closed georgekinnear closed 3 years ago

georgekinnear commented 3 years ago

I've clicked on the "Comparison comments" button and was able to see a table of the comments left by various judges.

I clicked on the "Judge" heading on that table, thinking that would sort the table alphabetically by judge. Instead this seems to break the page; I get a page with only the Moodle navigation on it, and the message:

Error reading from database

More information about this error https://docs.moodle.org/39/en/error/moodle/dmlreadexception

mod/assign/view.php?id=3560&action=viewpluginpage&plugin=comparativejudgement&pluginsubtype=assignsubmission&pluginaction=managecomparisoncomments

This seems to have broken the "comparison comments" page across all juding sessions for me, i.e. even on a different judging session I now see that error message. However it does not seem to affect other users (a different instructor has been able to click through and see the original table of comments). But it does seem like I have no way to reverse it as a user.

Presumably it's to do with the way the table sorting preference is being saved.

andrewhancox commented 3 years ago

I've just pushed a fix for this - there was a badly named column.