search

ianjones / moodle-assignsubmission_comparativejudgement

GNU General Public License v3.0
3 stars 3 forks source link

Import comments does nothing #5

Closed mudrd8mz closed 3 years ago

mudrd8mz commented 4 years ago

Clicking "Comparison comments > Import comments" seems to do nothing in my case. Might be because of lack of some actual data. But I would expect at least some feedback. Also, it does not redirect after finishing whatever it does. So pressing F5 would re-send the POST form. That's not expected - all DB changing actions should end up redirecting to a GET page.

andrewhancox commented 3 years ago

The process of importing comments was idempotent so refreshing wouldn't have been an issue in this case. I've put the re-direct and alert in place though in case the feature changes in the future.