ianklatzco / psky.app

vxtwitter for bsky (preview urls by rewriting them)
MIT License
63 stars 2 forks source link

500 server error #6

Closed jasikpark closed 1 year ago

jasikpark commented 1 year ago
image

ty for building this sweet preview app 💜

https://psky.app/profile/xn--u38h.jasik.xyz/post/3juses57v4627, and most urls, seem to be throwing a 500 error

image
ianklatzco commented 1 year ago

ty report!!! should be fixed.

god, this code is ugly. needs a rewrite.

jasikpark commented 1 year ago

hmm i'm still seeing the same error page for that link?

yafesdot commented 1 year ago

So the problem is something with the fxbsky.app domain. We'll take care of the situation! Thanks for the report!

jasikpark commented 1 year ago

cool, thx for sorting it out!

ianklatzco commented 1 year ago

either my code's bad or there's something nondeterministic with the bsky api - maybe things not hydrated every time?

jasikpark commented 1 year ago

hmm currently loading the url in the issue description ends up redirecting me to the staging.bsky.app version of the url?

ianklatzco commented 1 year ago

yeah yeah! that's a ux thing -- if ppl click the psky url, they should get to the staging.bsky.app view of the tweet

mobile ios doesn't open any kind of bsky urls in-app i think

jasikpark commented 1 year ago

yay something made it start working again....

ianklatzco commented 1 year ago

me c: image https://github.com/ianklatzco/psky.app/commit/fda2c6738a18eda84ab79ca8f54d0d975f4d232b#diff-b10564ab7d2c520cdd0243874879fb0a782862c3c902ab535faabe57d5a505e1L264

ianklatzco commented 1 year ago

if someone wants to help out you could duplicate generate_html_with_image to a new generate_html_with_image_for_external_embed that tries pulling the image url out of an embed with $type:external 🥺