iankressin / eql

Query language to interact with EVM chains

https://eql.sh

MIT License

61 stars 5 forks source link

Improve error readbility #28

Closed yulesa closed 2 months ago

yulesa commented 3 months ago

Summary

Add an error print (eprintln!) in the CLI main.rs file to improve the readability of the EQL expressions errors.

Associated issue

https://github.com/iankressin/eql/issues/27#issue-2456537429

yulesa commented 3 months ago

I'm not sure if the solution I gave is the best. As you can see in the print below, the debug error showed by upstreaming the error up to main is more detailed than the eprintln! output. However, it greatly improves the parsing error, which I think will be the most common for users trying the repo.

iankressin commented 2 months ago

I'm not sure if the solution I gave is the best. As you can see in the print below, the debug error showed by upstreaming the error up to main is more detailed than the eprintln! output. However, it greatly improves the parsing error, which I think will be the most common for users trying the repo.

Yeah, you're fix seems reasonable. Thanks for the PR :sunglasses: