search

iankressin / eql

Query language to interact with EVM chains
https://eql.sh
MIT License
67 stars 7 forks source link

Handle RPC request failures gracefully - Accounts #56

Open iankressin opened 3 days ago

iankressin commented 3 days ago

Describe the solution you'd like In the current implementation, if a single RPC call fails, the whole query fails. RPC request errors should be handled gracefully, returning None for the fields which the value couldn't be fetched in that query.

In the case of accounts, if one of the calls made inside the get_account method fails, should return None, instead of throwing an error. https://github.com/iankressin/eql/blob/1579a394b73db96a96adc61ac3ec0d6c77dc9eb0/crates/core/src/interpreter/backend/resolve_account.rs#L60

Additional context You can attest the current behavior in the link below, where one of the RPCs is failing to respond the request and the whole query fails. https://eql.sh/?query=GET+*+FROM+account+vitalik.eth+ON+*

Krishn1412 commented 3 days ago

Can you assign this to me @iankressin ?

iankressin commented 2 days ago

Can you assign this to me @iankressin ?

Done!