search

iankronquist / y-cloninator

List GitHub projects trending on Hacker News without distractions.
http://ycloninator.herokuapp.com/
MIT License
127 stars 13 forks source link

search improvements #3

Closed tschuy closed 8 years ago

tschuy commented 8 years ago

@iankronquist

This fixes #2 and #1. It makes the language clickable in the search results, and makes language results case insensitive.

tschuy commented 8 years ago

It also orders by newest first.

tschuy commented 8 years ago

(Oh, I should mention, I already pushed this to production.)

iankronquist commented 8 years ago

There is a bug in this PR. If you click on Python to filter Python projects, and then you enter another term in the search box and hit Search you'll get an error that you can't post to '/Python'. Steps to reproduce:

  1. Load the page
  2. Click 'Python' (or some other language)
  3. Enter C++ in the search box & hit enter
  4. Get a cruddy page with this error: Cannot POST /Python
iankronquist commented 8 years ago

Line 5 in index.hjs probably needs to have an explicit post target.

iankronquist commented 8 years ago

Looks good to me. Merging.