ianlee-dev / facebook-java-api

Automatically exported from code.google.com/p/facebook-java-api
0 stars 0 forks source link

2.0.3 Close io streams and disconnect from server patch #135

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I think we should close input and output streams and call disconnect after
we receive all data from facebook. 

This is a patch for 395 revision

Original issue reported on code.google.com by rdmytre...@gmail.com on 10 Nov 2008 at 1:54

Attachments:

GoogleCodeExporter commented 8 years ago
thank you.

I'll look into this..  I'll try to incorporate your idea, but I just don't like 
the
system capturing the full response into a String object, before passing it 
around to
re -parse it, etc etc..

But you're right, I don't think we were properly closing the stream :)

Original comment by fern...@gmail.com on 18 Nov 2008 at 3:30

GoogleCodeExporter commented 8 years ago
well. sadly, it looks like capturing it as string first is baked into the 
current
library :(  so I'll review your patch again, pretty good. :)

Original comment by fern...@gmail.com on 18 Nov 2008 at 3:34

GoogleCodeExporter commented 8 years ago
thank you. it's in there now :)

Original comment by fern...@gmail.com on 18 Nov 2008 at 3:45