ianlee-dev / facebook-java-api

Automatically exported from code.google.com/p/facebook-java-api
0 stars 0 forks source link

does batching more than 20 work? #151

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
sorry, this is not so much a bug as a clarification:  

facebook's batching allows up to 20 calls (it used to be 15, but they 
increased it, which is not reflected in the latest stable api code).  does 
the api client allow batching more than 20 calls and splits them up 
appropriately?  if so, it seems that it doesn't work.  if not, maybe there 
should be some more defensive code against batching more than 20.  
specifically, the while loop in FacebookJsonResetClient::executeBatch will 
continue after consuming the first 20 queries, but wont necessarily do 
anything with queries after 20.   thanks

Original issue reported on code.google.com by thien.p....@gmail.com on 15 Dec 2008 at 9:40

GoogleCodeExporter commented 8 years ago
There's already code in each of the FacebookRestClient's executeBatch() methods 
to
separate calls into chunks of 15. Sounds like that should be extended to 20. 
I'm sure
that's simple enough and we can do this as part of this bug report once I've 
verified
that 20 batches works.

However, I have no reason to believe that the batching won't work properly; 
chunking
to 15 per batch. Do you have a reason to doubt that the multiple batches don't 
work?
Do you have example code against 2.0.3 which shows it not working?

If you're a Java developer, it would be great if you could contribute a JUnit 
test
for this.

Original comment by david.j....@googlemail.com on 17 Dec 2008 at 9:06

GoogleCodeExporter commented 8 years ago

Original comment by david.j....@googlemail.com on 17 Dec 2008 at 9:06

GoogleCodeExporter commented 8 years ago
Batch limit updated to be 20.

Original comment by david.j....@googlemail.com on 21 Dec 2008 at 6:24