ianlee-dev / facebook-java-api

Automatically exported from code.google.com/p/facebook-java-api
0 stars 0 forks source link

events_get rsvp filter not working #192

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Initialize a FacebookJsonRestClient
2. call the events_get method with the following parameters: userId = your
user id, eventsid = null, start time = null, end time = null,
rsvp_status="attending"
3. Check the events and you'll see events which you didn't attend

What is the expected output? What do you see instead?
The client is returning all the events related to the specified userId, in
spite of the rsvp_status parameter. For instance, the example above is
returning "attending", "unsure", "declined" and "not_replied" events.

What version of the product are you using? On what operating system?
- facebook java api 2.1.0
- Mac OSX 10.5

Please provide any additional information below.

Original issue reported on code.google.com by andres...@gmail.com on 20 Apr 2009 at 12:29

GoogleCodeExporter commented 8 years ago
It seems this issue is also occuring with the FacebookJaxbRestClient

Original comment by andres...@gmail.com on 20 Apr 2009 at 12:42

GoogleCodeExporter commented 8 years ago
Can you use a debugger or turn on debug level logging to see if the parameter 
is 
actually being passed to the Facebook server?

Original comment by david.j....@googlemail.com on 1 May 2009 at 7:05

GoogleCodeExporter commented 8 years ago
ExtensibleClient.java's events_get method ignores the rsvp_status param and 
does not pass add it to the 
params array.

        public Object events_get( Long userId, Collection<Long> eventIds, Long startTime, Long endTime, String 
rsvp_status ) throws FacebookException {
                List<Pair<String,CharSequence>> params = new ArrayList<Pair<String,CharSequence>>( 4 );
                addParamIfNotBlankZero( "uid", userId, params );
                addParamDelimitIfNotBlankEmpty( "eids", eventIds, params );
                addParamIfNotBlankZero( "start_time", startTime, params );
                addParamIfNotBlankZero( "end_time", endTime, params );
                return callMethod( FacebookMethod.EVENTS_GET, params );
        }

Original comment by tob...@gmail.com on 30 Dec 2009 at 1:34

GoogleCodeExporter commented 8 years ago
So it is a bug, correct?

Original comment by andres...@gmail.com on 2 Jan 2010 at 5:20

GoogleCodeExporter commented 8 years ago
Yes, this is a bug... The events_get method never adds the rsvp_status to the 
params list object. (: I'd be willing 
to make the fixes (plus a few others I've found), if I had rights to contribute 
to the repository.

Original comment by tob...@gmail.com on 13 Jan 2010 at 6:36

GoogleCodeExporter commented 8 years ago
I've given you commit privileges. Please consider adding JUnit tests and please 
ensure 
that all JUnit tests run before committing code. Many thanks.

Original comment by david.j....@googlemail.com on 13 Jan 2010 at 8:56

GoogleCodeExporter commented 8 years ago

Original comment by david.j....@googlemail.com on 13 Jan 2010 at 8:56