search

ianleggett / TinanceUI

0 stars 0 forks source link

Deposit button - better user experience #38

Closed ianleggett closed 3 years ago

ianleggett commented 3 years ago

When deposit button is pressed, we need the circular progress Icon to appear straight away. I have already placed it but it does not work: TradeList.tsx image

laozhu commented 3 years ago

Add fullscreen depositing overlay

ianleggett commented 3 years ago

User experience is not great still ! When button is pushed, make it disabled and put spinner icon on it straight away. tinance-deposit-3

meditations commented 3 years ago

Need to enable the overlay straightaway

laozhu commented 3 years ago

fixed @meditations

meditations commented 3 years ago

Overlay works good, but it's slightly lagging behind when the deposit completes, and the buyer's page has been refreshed, but the seller's page is still on overlay.

Can we disable the overlay as soon as the deposit completes. @laozhu

laozhu commented 3 years ago

@meditations I use preDepositing and depositing to control the visibility of overlay, If the deposite trade request is done, the depositing state will be set to false automatically, I don't know where is the trigger of the truely "deposit complete", it's not the same as deposite trade request complete?

Where I define depositing state:

https://github.com/ianleggett/TinanceUI/blob/lin_carnival_integration/tinance-ui/src/pages/TradeList.tsx#L282

ianleggett commented 3 years ago

fixed