ianlewis / todos

Parse TODO and FIXME comments from code
Apache License 2.0
26 stars 2 forks source link

fix: exclude-dir not matching with path separator #1465

Closed ianlewis closed 7 months ago

ianlewis commented 7 months ago

Description:

--exclude-dir now ignores trailing path separators on the directory name passed to it. This is since it's natural to pass something like mydir/ as a directory name.

Related Issues:

Fixes #1463

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (95753d7) 79.16% compared to head (3abda3f) 79.16%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ianlewis/todos/pull/1465/graphs/tree.svg?width=650&height=150&src=pr&token=0EBN8DQYFR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ian+Lewis)](https://app.codecov.io/gh/ianlewis/todos/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ian+Lewis) ```diff @@ Coverage Diff @@ ## main #1465 +/- ## ======================================= Coverage 79.16% 79.16% ======================================= Files 15 15 Lines 907 907 ======================================= Hits 718 718 Misses 138 138 Partials 51 51 ``` | [Files](https://app.codecov.io/gh/ianlewis/todos/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ian+Lewis) | Coverage Δ | | |---|---|---| | [internal/cmd/todos/app.go](https://app.codecov.io/gh/ianlewis/todos/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ian+Lewis#diff-aW50ZXJuYWwvY21kL3RvZG9zL2FwcC5nbw==) | `85.77% <100.00%> (ø)` | |