ianloic / rdio-export

Export your Rdio favorites and playlists to Google Play Music
GNU General Public License v3.0
8 stars 2 forks source link

Remove usage of User.trackCount #4

Closed yns88 closed 8 years ago

yns88 commented 8 years ago

User.trackCount is an old deprecated field that now returns 0 for most users, regardless of their favorites. The proper way to get a Favorites count from the API is to use a more recent API version and take the 'total' value from the getFavorites API result, but that's fairly complicated and IMO the count is not that important to have here.

ianloic commented 8 years ago

I actually just noticed this trying to migrate a friend's tracks and was fixing it in my own branch. Thanks for the PR - I'll close it once I've verified & pushed my fix.

ianloic commented 8 years ago

Fixed in https://github.com/ianloic/rdio-export/commit/c74277e8cba6785c631ae68dbbb83548e693b83e

Let me know if it's still broken for you.