ianmackenzie / elm-3d-scene

A high-level 3D rendering engine for Elm, with support for lighting, shadows, and realistic materials.
https://package.elm-lang.org/packages/ianmackenzie/elm-3d-scene/latest/
Mozilla Public License 2.0
205 stars 27 forks source link

Demo for testing lights and materials #64

Closed w0rm closed 4 years ago

w0rm commented 4 years ago

Closes #38

elm-3d-scene

  1. This code breaks elm-format :(
  2. Logarithmic scale is probably needed for some parameters
  3. The furniture and floor are not configurable, maybe we should give them realistic colors
  4. The background is not changing, what should it be — just a color picker?
  5. Bulbs do not change their color depending on the temperature
  6. Bulbs cannot be moved at the moment
  7. The styling of Html could be better, but I wanted to keep it simple
ianmackenzie commented 4 years ago

Looking good! I agree that the furniture and floor should ideally have realistic colors - one of my hopes for this demo is that it looks realistic enough that people can accurately figure out good lighting values by just looking at the scene and asking themselves if it "looks natural". For background, I think transparent is probably fine.

A few notes:

w0rm commented 4 years ago

@ianmackenzie I addressed your notes, let me know if there is anything else that we can improve for MVP

ianmackenzie commented 4 years ago

This is looking good! I'm thinking of merging it in as is and then playing around with a few things. I might try to add something like https://cc0textures.com/view?tex=Wood34 to the table, for example - I kind of like the idea that a chunk of the scene (tables and chairs) should be as realistic as possible (not configurable) so that lighting values can be assessed easily, and then the sphere/cylinder/block on the table can be used for experimenting with all sorts of crazy materials.

Do you have strong opinions on having the UI on the left vs. right side? I think I personally prefer the left, so it's in order input -> output...

w0rm commented 4 years ago

@ianmackenzie I don't have any strong opinion about the layout. Feel free to rearrange things to your preference!