ianmackenzie / elm-geometry

2D/3D geometry package for Elm
Mozilla Public License 2.0
183 stars 26 forks source link

Add velocity/acceleration/force vector constructors? #127

Closed ianmackenzie closed 3 years ago

ianmackenzie commented 4 years ago

Vector3d.kilometersPerHour, Vector3d.metersPerSecondSquared, Vector3d.newtons etc.

Would be quite a few extra functions but could make working with things like elm-physics more convenient.

ianmackenzie commented 4 years ago

Perhaps put these in a 'Physics' section or similar towards the bottom of the documentation, so that they don't clutter things up too much?

g-belmonte commented 3 years ago

Hmm... this seems interesting! Can I help out somehow? :smile:

ianmackenzie commented 3 years ago

Certainly! Feel free to take a crack at it, I'll assign this issue to you =)

Don't be shy about opening up a work-in-progress pull request once you have a bit of code in place - happy to provide feedback on an initial version, suggest additional constructors that might be useful, etc.

ianmackenzie commented 3 years ago

Implemented in #139, thanks @g-belmonte! It's possible we'll think of more units to add here in the future but I think for now this can be closed.