ianmackenzie / elm-geometry

2D/3D geometry package for Elm
Mozilla Public License 2.0
183 stars 26 forks source link

Add intersectionWithSphere function #128

Closed SuzzzWood closed 4 years ago

SuzzzWood commented 4 years ago

Added intersectionWithSphere function Maths from wikipedia

tv2

ianmackenzie commented 4 years ago

Looks good! (And don't worry about the Travis build failure - I checked and it's an unrelated test that's failing, one that fails occasionally and I have to look into at some point but not related to any of this work.)

I was going to make a couple minor tweaks but I'm not sure I have write access to your axis-sphere-intersection branch - is the "Allow edits from maintainers" box checked? The changes are basically:

SuzzzWood commented 4 years ago

@ianmackenzie thanks for the feedback! Yes, 'Allow edits from maintainers' is checked, feel free to edit

ianmackenzie commented 4 years ago

Just added a fuzz test for axis/sphere intersection - everything passes, so this looks good!

One last change: could you add yourself to the AUTHORS file? =)

SuzzzWood commented 4 years ago

Nice! Have added, thanks