search

ianmackenzie / elm-units

Simple, safe and convenient unit types and conversions for Elm
https://package.elm-lang.org/packages/ianmackenzie/elm-units/latest/
BSD 3-Clause "New" or "Revised" License
85 stars 14 forks source link

Capacitance module added. #12

Closed ukarim closed 6 years ago

ianmackenzie commented 6 years ago

Looking good! Just made a few small changes, most significantly changing picoFarads to picofarads - I think this is a bit more accurate and consistent with what other elm-units modules do. Could you also add microfarads and nanofarads?

ianmackenzie commented 6 years ago

Oh, and go ahead and add yourself to the AUTHORS file as well! Don't have to provide e-mail address if you'd prefer not to, GitHub username is fine.

ukarim commented 6 years ago

@ianmackenzie I've just added functions for micro and nano farads.

ianmackenzie commented 6 years ago

Looks good! Just had to add @docs entries for those new functions =)

ianmackenzie commented 6 years ago

(Also, apologies for the late reply - I'm in the middle of a move so I haven't had much access to my computer.)