Closed lenards closed 5 years ago
@ianmackenzie / Ian - can you tag this with Hacktoberfest label?
Checking the failure.
onSave
hook in my editor was not applying elm-format
. Apply elm-format, squash changes in rebase to avoid any extraneous commits in the pull request.
Just added a section to the introductory docs describing how a Molarity
value can be worked with as a rate - is this roughly what you meant by "A good example in the module comment"?
Would probably be even better to have some full examples with actual values, but then that should probably be done for all other similar modules as well (Speed
, Pressure
, Current
etc.).
I appreciate the additional commits. Also want to pre-apologize for not getting those bits in the branch before the PR was created.
No, not at all! I quite enjoy working on PRs collaboratively, I think it works quite well.
I think this is pretty much ready to merge, but one last thing - can you add yourself to the AUTHORS file? 🙂
Added myself 🙇
Thank you Ian!
Looks good, thanks!
Relates to #6. Applies feedback from #42.
Work Done
In
SubstanceAmount
module:decimoles
,inDecimoles
,centimoles
,inCentimoles
In
Molarity
module:molesPerLiter
,inMolesPerLiter
decimolesPerLiter
,inDecimolesPerLiter
centimolesPerLiter
,inCentimolesPerLiter
millimolesPerLiter
,inMillimolesPerLiter
micromolesPerLiter
,inMicromolesPerLiter
What Is Missing?
molesPerLiter
,inMolesPerLiter
Because
Molarity
is defining the value as aRate
, and there is not direct access to a numerator and denomerator, I am not sure what that because what to definemolesPerLiter
givenmolesPerCubicMeter
and/ordecimolesPerLiter
.A good example in the module comment
My lack of familiarity with concentration, or amount-of-substance of concentration, means that I'm not sure what a good usage example would be to include in the module comment. I would appreciate thoughts, suggestions, etc.
Thank you
I appreciate the feedback on the draft pull request, see #42. Thank you for your time in considering this contribution.