Closed mdevlamynck closed 6 years ago
Thanks for the PR, looks good! Just a couple comments (these are entirely my fault for not having set up a proper CONTRIBUTING.md yet):
master
branch as a perfect copy of the upstream repository, which is important especially if the PR is not merged (since then the commits you added in your master
branch will never show up in the upstream master
and the two will become out of sync). (It also means you can more easily have multiple PRs open at the same time and work on them in parallel.)By the way, am I correct in assuming you found this through Hacktoberfest? It's always nice to know that it is indeed worth the little bit of time effort to find and prepare Hacktoberfest-friendly issues =)
No, don't worry about the branch, that's really more for your benefit...and this pull request will get merged very soon, so you shouldn't have to worry about your fork getting out of sync =)
Oh, and I forgot to mention but yes the pixelsPerSecondSquared
/inPixelsPerSecondSquared
was just a plain oversight on my part - thanks for catching that!
Fixes #5.
Adds a function to fuzz test conversion from Float to Quantity and Quantity to Float and use it to test all such conversion functions.
While doing this I noticed that
Pixels.pixelsPerSecondSquared
andPixels.inPixelsPerSecondSquared
are not exposed. Is this on purpose or a mistake?