ianmackenzie / elm-units

Simple, safe and convenient unit types and conversions for Elm
https://package.elm-lang.org/packages/ianmackenzie/elm-units/latest/
BSD 3-Clause "New" or "Revised" License
85 stars 14 forks source link

Add fuzz tests on Float to Quantity and Quantity to Float functions #7

Closed mdevlamynck closed 6 years ago

mdevlamynck commented 6 years ago

Fixes #5.

Adds a function to fuzz test conversion from Float to Quantity and Quantity to Float and use it to test all such conversion functions.

While doing this I noticed that Pixels.pixelsPerSecondSquared and Pixels.inPixelsPerSecondSquared are not exposed. Is this on purpose or a mistake?

ianmackenzie commented 6 years ago

Thanks for the PR, looks good! Just a couple comments (these are entirely my fault for not having set up a proper CONTRIBUTING.md yet):

By the way, am I correct in assuming you found this through Hacktoberfest? It's always nice to know that it is indeed worth the little bit of time effort to find and prepare Hacktoberfest-friendly issues =)

mdevlamynck commented 6 years ago
ianmackenzie commented 6 years ago

No, don't worry about the branch, that's really more for your benefit...and this pull request will get merged very soon, so you shouldn't have to worry about your fork getting out of sync =)

Oh, and I forgot to mention but yes the pixelsPerSecondSquared/inPixelsPerSecondSquared was just a plain oversight on my part - thanks for catching that!