search

ianmacl / patchtester

13 stars 53 forks source link

Error handling #5

Closed elkuku closed 12 years ago

elkuku commented 12 years ago

Beside from using exceptions and being more communicative when reporting errors, cURL is used instead of streams for applying patches. Maybe this fixes #1 ?

ianmacl commented 12 years ago

Overall looks very good. However, I think we need to deal with the JHttp/JCurl thing by making JHttp more robust to be able to switch between fopen/streams and curl. I'd then like to refactor JGithub a bit to use JHttp for all of its requests once we get JHttp fixed up.

On second thought, since this is a solution to get things working now, I'll pull this and then fix the upstream library and merge that back in when it's ready.

ianmacl commented 12 years ago

So let's just change the JError call appropriately and we'll merge it in.

Excellent work!

elkuku commented 12 years ago

Would this be OK ?