ianmarmour / nvidia-clerk

A cross-platform go bot that tracks for availability of stock from Nvidia's store and adds a cart to your checkout.
BSD 3-Clause "New" or "Revised" License
222 stars 64 forks source link

Break on line 90 - main.go #101

Closed reubenprevost closed 3 years ago

reubenprevost commented 3 years ago

Break on line 90 in main.go breaks the loop

Also -discord flag and -remote flag causes problems

V3.2

ianmarmour commented 3 years ago

Yep sorry about that, using test mode only iterates a single time and I'm not testing the main loop sigh. Removed 3.3, I've been testing sms and that's been working still trying to look into discord (I had thought it was fixed but I guess I was wrong)

fokeiro2020 commented 3 years ago

Yep sorry about that, using test mode only iterates a single time and I'm not testing the main loop sigh. Removed 3.3, I've been testing sms and that's been working still trying to look into discord (I had thought it was fixed but I guess I was wrong)

sms is sending a bad link to an empty shopping cart

ianmarmour commented 3 years ago

@fokeiro2020 Can you run it a few times, apparently we've been seeing inconsistent results with the sms (I've had it work on LAN/LTE and after clearing my browser cache multiple times). Other folks haven't.

reubenprevost commented 3 years ago

Yep sorry about that, using test mode only iterates a single time and I'm not testing the main loop sigh. Removed 3.3, I've been testing sms and that's been working still trying to look into discord (I had thought it was fixed but I guess I was wrong)

sms is sending a bad link to an empty shopping cart

I'm curious, what mobile OS are you using (andriod or IOS)? also, are you using a web interface to access your messages (like messages.google.com)?

@ianmarmour Do you think it's because these apps like discord are accessing the link first? I really don't know, just guessing.

ianmarmour commented 3 years ago

I'm using messenger built into IOS (and yes, that's one theory I have)

fokeiro2020 commented 3 years ago

Yep sorry about that, using test mode only iterates a single time and I'm not testing the main loop sigh. Removed 3.3, I've been testing sms and that's been working still trying to look into discord (I had thought it was fixed but I guess I was wrong)

sms is sending a bad link to an empty shopping cart

I'm curious, what mobile OS are you using (andriod or IOS)? also, are you using a web interface to access your messages (like messages.google.com)?

@ianmarmour Do you think it's because these apps like discord are accessing the link first? I really don't know, just guessing.

Android s10+ , google sms app and link open to chrome

ianmarmour commented 3 years ago

@rjprevost So just verified manually sending a link through gmail to someone else.... that worked fine, did the same thing via discord and it breaks...

Pretty sure discord is monitoring people's posted links and visiting them.... real creepy.

reubenprevost commented 3 years ago

Yeah, that's what I'm thinking.

I think Google sms is doing the same thing, though I've only tested it via their webapp (messages.google.com)

ianmarmour commented 3 years ago

Yeah I'm 99.99% sure this is why :/ not really sure the best way to get around this (but hey it's nice to know Apple isn't harvesting url metadata on cellphones (maybe they are concerned about privacy)

ianmarmour commented 3 years ago

So I think I may have cracked it... pretty sure discord attempts auto embeds unless you wrap a link in <>

reubenprevost commented 3 years ago

That makes sense. I'll test it real quick.

ianmarmour commented 3 years ago

nvidia-clerk-windows.zip Here's a build with the change

reubenprevost commented 3 years ago

I'm running a mac, but I think it worked for me. Just added the <> and it seemed to work fine.

ianmarmour commented 3 years ago

Awesome also for your sms, I think you can just disable the link preview feature on android.

reubenprevost commented 3 years ago

Not going to test sms right now, but Discord is working consistently. That fixed it.

ndemos commented 3 years ago

Disabling link preview fixed the sms link for me! Good catch.

ianmarmour commented 3 years ago

https://github.com/ianmarmour/nvidia-clerk/releases/tag/v3.5