ianmartorell / meteor-accounts-ui-bootstrap-3

accounts-ui package with Bootstrap 3 and localization support
150 stars 109 forks source link

Compatibility with fezvrasta's bootstrap material design theme #104

Closed dandv closed 9 years ago

dandv commented 9 years ago

This may be more of an issue with @fezvrasta's bootstrap material design theme, but on narrow screens, the Forgot Password and Create Account links are invisible due to taking the same color as the background:

image

The markup is the one from the Example.

ianmartorell commented 9 years ago

I see, I'll try to take a look later today.

ianmartorell commented 9 years ago

The problem comes from the change of background color, which goes from white on wide displays to green on narrow ones. With the default Bootstrap colors this is not noticeable because it goes from white to light gray, and the colors of the dropdown still work fine. In this case though the color scheme should be reversed to work on a dark background. It's not only the links on the bottom having the same color as the background, it's also affecting the inputs' highlights (the selected input should be highlighted but you can't see it because it has the same color as the background) and the readability of their contents. The button shouldn't have the same color either even if its text is readable. I'm not sure how I would go about fixing this though... I would say it's a bug on fezvrasta's package as this will happen to all dropdowns in a navbar.

dandv commented 9 years ago

As a workaround I added a CSS rule for the two links,

#signup-link, #forgot-password-link {
  color: black;
}  

That is a pretty bad workaround though so I took a screencast and filed an issue with @fezvrasta's repo.

dandv commented 9 years ago

Hey @fezvrasta - looks like the theme needs to ensure that the link looks good on the navbar background. I've filed a similar issue for some Bootswatch themes, and the author has just fixed it.

ianmartorell commented 9 years ago

Closed as it's a theme issue