search

ianmartorell / meteor-accounts-ui-bootstrap-3

accounts-ui package with Bootstrap 3 and localization support
150 stars 109 forks source link

Google OAuth needs `?close` appended to URL #109

Closed dandv closed 9 years ago

dandv commented 9 years ago

I initially thought this was a Meteor issue and reported it at https://github.com/meteor/meteor/issues/4246, but without accounts-ui-bootstrap-3, I can't reproduce it.

image

Nothing special to reproduce; just create the skeleton app, meteor add accounts-google accounts-ui-bootstrap-3 twbs:bootstrap and add {{> loginButtons}}. Then configure authentication with Google.

Here's a reproduction repo anyway: https://github.com/dandv/meteor-issue-4224

ecwyne commented 9 years ago

I believe this is because ian:accounts-ui-bootstrap-3 is using accounts-oauth@1.0.0 the most recent version is 1.1.5

ecwyne commented 9 years ago

Figured it out!

The method call here is expecting a loginStyle property that is either popup or redirect. If that property is not present then the ?close is added to the redirectURI here

ianmartorell commented 9 years ago

Wow @ecwyne, that's definitely it! I'll update the package in a moment

dandv commented 9 years ago

Thank you gentlemen. :cool: