search

ianmartorell / meteor-accounts-ui-bootstrap-3

accounts-ui package with Bootstrap 3 and localization support
150 stars 109 forks source link

Radio elements as extra signup fields. #124

Closed shriharshmishra closed 9 years ago

shriharshmishra commented 9 years ago

Hi,

I have added code to allow radio elements as extra signup fields as well as the documentation. Please review.

Thanks!

ianmartorell commented 9 years ago

Nice work!! But there seems to be a bug, the email field doesn't show up for some reason. Does this happen to you as well?

screen shot 2015-05-25 at 12 31 33

screen shot 2015-05-25 at 12 35 41

The same configuration with and without your patch makes the email field appear or disappear. Also, I don't know if it's a problem with this package or with the theme, but it doesn't work with fezvrasta's bootstrap material design:

screen shot 2015-05-25 at 12 32 23

shriharshmishra commented 9 years ago

I guess I know the problem. I will fix and revert. Thanks!

On 25-May-2015, at 4:06 pm, Ian Martorell notifications@github.com wrote:

Nice work!! But there seems to be a bug, the email field doesn't show up for some reason. Does this happen to you as well?

The same configuration with and without your patch makes the email field appear or disappear. Also, I don't know if it's a problem with this package or with the theme, but it doesn't work with fezvrasta's bootstrap material design:

— Reply to this email directly or view it on GitHub.

shriharshmishra commented 9 years ago

I have fixed the missing email issue. Please check.

I tried making this work with bootstrap material design but there seems to be some CSS or JS issue.

ianmartorell commented 9 years ago

Thanks, I did some minor changes too, so the inputs are in the same div and the spacing doesn't look weird.

shriharshmishra commented 9 years ago

Great! Thanks!