search

ianmartorell / meteor-accounts-ui-bootstrap-3

accounts-ui package with Bootstrap 3 and localization support
150 stars 109 forks source link

Don't declare dependency on twbs:bootstrap #152

Closed jay-depot closed 9 years ago

jay-depot commented 9 years ago

After running a meteor update, I noticed that my project suddenly has twbs:bootstrap added to it. I've traced it down to two packages declaring a hard dependency on twbs:bootstrap. One of them was this one.

We use nemo64:bootstrap because it is very easy to customize, and adding twbs:bootstrap conflicts with it and causes our stylesheets to break.

Please don't declare a hard dependency on a specific bootstrap package.

ianmartorell commented 9 years ago

This package has a weak dependency on both twbs:bootstrap and nemo64:bootstrap, you can check the package.js.

jay-depot commented 9 years ago

Interesting, Thanks.

So it should be the other of the two packages that caused the issue.

jay-depot commented 9 years ago

Yep, it was the other package, and it looks like they fixed it.

https://github.com/meteor-factory/meteor-admin-lte/issues/5