search

ianmartorell / meteor-accounts-ui-bootstrap-3

accounts-ui package with Bootstrap 3 and localization support
150 stars 109 forks source link

Create ar.i18n.js #38

Closed ghost closed 9 years ago

ghost commented 9 years ago

Arabic support

ianmartorell commented 9 years ago

I don't know any arabic, but does it look like it's supposed to look like? Isn't arabic written from right to left? Also, it's missing the translation loginButtonsLoggedOutDropdown.up. In English you can say "Sign in / up" but as this doesn't work in many other languages, translating that value to "Sign up" works fine. And why is the translation in loginButtonsLoggedOutDropdown.signIn different from the one in loginButtonsLoggedOutPasswordService.signIn?

ghost commented 9 years ago

Yes, Arabic is RTL but this is handled via css "Like Bootstrap-RTL Package". I must ,missed 'up' i'll get back to it. about "loginButtonsLoggedOutDropdown.signIn" and "loginButtonsLoggedOutPasswordService.signIn", Arabic is context driven language so in the first string it says "Log in" as a word not a verb, on the other string it's a verb, which make sense for me.

I am editing it now a little to match this standards : http://www.arabeyes.org

ianmartorell commented 9 years ago

I see! Thanks for the clarification.

I guess I don't have to worry about RTL then.