search

ianmcook / tidyquery

Query R data frames with SQL
Apache License 2.0
167 stars 12 forks source link

Support the arrow package #27

Closed eitsupi closed 2 years ago

eitsupi commented 2 years ago

Thanks for creating this great package.

Since the package I recently created can be used with tidyquery^1, I thought it would be even more wonderful to be able to support arrow here. Please let me know if there is anything you think needs to be done to support arrow so I may work on it.

Close #16

eitsupi commented 2 years ago

Travis CI seems to have failed to install arrow. I can help you set up GitHub Actions if you like.

ianmcook commented 2 years ago

Thank you! I will take a closer look at this soon.

ianmcook commented 2 years ago

I migrated the CI to GitHub Actions, rebased your PR branch to re-run the checks, and merged your PR. I will make some additional changes in subsequent commits that will affect how tidyquery works with arrow. If any of these changes break your integration with prqlr, please let me know. Thanks!

eitsupi commented 2 years ago

Thanks for working on that!

ianmcook commented 1 year ago

I expanded the tests on Arrow objects in https://github.com/ianmcook/tidyquery/commit/b97f4e25ceb5c65102dfe270d213760108171e0b