search

ianmiell / shutit

Automation framework for programmers
http://ianmiell.github.io/shutit/
MIT License
2.15k stars 110 forks source link

video problems #272

Closed ianmiell closed 7 years ago

ianmiell commented 7 years ago

Running the k8s-the-hard-way script I see issues with video and empty outputs.

Probably a timing issue.

ianmiell commented 7 years ago

Repro: imiell@rothko:/space/git/shutit-k8s-the-hard-way.tmp (master)$ ./run.sh --video 2

ianmiell commented 7 years ago

The same does not happen for walkthough (which video switches on by implication)

ianmiell commented 7 years ago

Fails.

            if type(args.video) == list and args.video[0] >= 0:                                                                                                                   
                shutit.build['walkthrough']      = True                                                                                                                           
               shutit.build['walkthrough_wait'] = float(args.video[0])                                                                                                           
            #   shutit.build['video']            = True                                                                                                                           
            #   if shutit.build['training']:                                                                                                                                      
            #       print('--video and --training mode incompatible')                                                                                                             
            #       handle_exit(exit_code=1)                                                                                                                                      
            #   if shutit.build['testing']:                                                                                                                                       
            #       print('--video and --testing mode incompatible')                                                                                                              
            #       handle_exit(exit_code=1)
ianmiell commented 7 years ago

Fine.

            if type(args.video) == list and args.video[0] >= 0:                                                                                                                   
                shutit.build['walkthrough']      = True                                                                                                                           
               shutit.build['walkthrough_wait'] = float(args.video[0])                                                                                                           
            #   shutit.build['video']            = True                                                                                                                           
            #   if shutit.build['training']:                                                                                                                                      
            #       print('--video and --training mode incompatible')                                                                                                             
            #       handle_exit(exit_code=1)                                                                                                                                      
            #   if shutit.build['testing']:                                                                                                                                       
            #       print('--video and --testing mode incompatible')                                                                                                              
            #       handle_exit(exit_code=1)
ianmiell commented 7 years ago

Changing this line makes it 'work' (tho it's not video mode anymore...):