search

ianmiell / shutit

Automation framework for programmers
http://ianmiell.github.io/shutit/
MIT License
2.15k stars 110 forks source link

dead code reported by vulture #302

Closed RJ722 closed 7 years ago

RJ722 commented 7 years ago

We used vulture (https://github.com/jendrikseipp/vulture) to search for unused code in your project. You can find the report below. It would be great if you could give us feedback about which items are actually used or unused. This would allow us to improve vulture and ideally it also helps you to remove obsolete code or even find typos and bugs.

Command:

vulture shutit --exclude venv

Raw Results:

shutit/emailer.py:148: Unused function 'add_line'
shutit/emailer.py:153: Unused function 'add_body'
shutit/package_map.py:117: Unused function 'find_package'
shutit/shutit_class.py:130: Unused function 'remove_section'
shutit/shutit_class.py:133: Unused function 'remove_option'
shutit/shutit_class.py:345: Unused attribute 'shutit_signal'
shutit/shutit_class.py:471: Unused function 'get_current_environment'
shutit/shutit_class.py:645: Unused variable 'practice'
shutit/shutit_class.py:646: Unused variable 'golf'
shutit/shutit_class.py:729: Unused function 'send_and_return_status'
shutit/shutit_class.py:935: Unused function 'send_host_file'
shutit/shutit_class.py:1198: Unused function 'insert_text'
shutit/shutit_class.py:1229: Unused function 'delete_text'
shutit/shutit_class.py:1393: Unused function 'user_exists'
shutit/shutit_class.py:1507: Unused function 'prompt_cfg'
shutit/shutit_class.py:1581: Unused function 'step_through'
shutit/shutit_class.py:1923: Unused variable 'exit_shell'
shutit/shutit_class.py:2302: Unused function 'begin_asciinema_session'
shutit/shutit_class.py:2330: Unused function 'end_asciinema_session'
shutit/shutit_class.py:2341: Unused function 'get_emailer'
shutit/shutit_class.py:2352: Unused attribute 'logfile_read'
shutit/shutit_class.py:2356: Unused function 'add_shutit_pexpect_session'
shutit/shutit_class.py:2364: Unused function 'remove_shutit_pexpect_session'
shutit/shutit_class.py:2384: Unused function 'get_shutit_pexpect_session_id'
shutit/shutit_class.py:3441: Unused attribute 'real_user_id'
shutit/shutit_exam.py:60: Unused function 'is_complete'
shutit/shutit_global.py:86: Unused attribute 'shutit_state_pickle_file'
shutit/shutit_global.py:195: Unused function 'print_stack_trace'
shutit/shutit_patterns/docker_tutorial.py:6: Unused variable 'configs_build_cnf_file'
shutit/shutit_patterns/docker_tutorial.py:43: Unused variable 'tutorial_py_file'
shutit/shutit_patterns/docker_tutorial.py:86: Unused variable 'eg_images_sh_file'
shutit/shutit_patterns/docker_tutorial.py:105: Unused function 'setup_docker_tutorial_pattern'
shutit/shutit_pexpect.py:2690: Unused variable 'send_and_expect'
shutit/shutit_util.py:165: Unused attribute 'daemon'

There might be false positives, which can be prevented by adding them to a whitelist file. You may find more info here

Regards, vulture team

ianmiell commented 7 years ago

Thanks, have taken a few of these as suggestions.