search

ianmiell / shutit

Automation framework for programmers
http://ianmiell.github.io/shutit/
MIT License
2.15k stars 110 forks source link

Moved from using sys.version_info.major and minor to use [0] and [1] #315

Closed postdestiny closed 6 years ago

postdestiny commented 6 years ago

When trying to run shutit from a box running python 2.6.6 the version check fails as sys.version_info.major doesn't exist. Moved to a more general format which allows it to fail nicely

Error:

lib/python2.6/site-packages/shutit_pexpect.py:47: DeprecationWarning: the md5 module is deprecated; use hashlib instead from md5 import md5 Traceback (most recent call last): File "/home/whiterob/.local/bin/shutit", line 11, in sys.exit(main()) File "/home/whiterob/.local/lib/python2.6/site-packages/shutit.py", line 66, in main if sys.version_info.major == 2: AttributeError: 'tuple' object has no attribute 'major'

ianmiell commented 6 years ago

Taking on trust as no python2.6 docker image can I find - building a release today, so a pip update should be available by tomorrow.

ianmiell commented 6 years ago

dockershelf/python:2.6

ianmiell commented 6 years ago

LGTM