search

ianmiller347 / feather-icons-react

Feather Icons as a React Component
46 stars 10 forks source link

Latest icons missing #1

Closed actuallydan closed 6 years ago

actuallydan commented 6 years ago

I noticed there are a few icons missing from more recent updates to the feather library, I was hoping you'd be willing and able to update this, as I prefer this library over react-feather.

I wanted to make the changes myself and then submit a PR but I think I'm misunderstanding the build process.

In case it's relevant here's the missing icons:

{"missing": ["archive", "arrow-down-circle", "arrow-left-circle", "arrow-right-circle", "arrow-up-circle", "book-open", "code", "database", "dollar-sign", "folder-minus", "folder-plus", "gift", "git-branch", "git-commit", "git-merge", "git-pull-request", "hard-drive", "linkedin", "rss", "send", "shield-off", "shopping-bag", "terminal", "truck", "youtube", "zap-off"]}

Any help is appreciated!

ianmiller347 commented 6 years ago

Hey! Thank you for opening this issue. I do plan to update this very soon as I was working on a way to automate the updates. Essentially I want to use the json generator from the feather repo and always have the latest icons. I have been working on this locally but haven't pushed up any changes yet. If you have any suggestions on helping implement this that would also help! If not I will try to get these updated within the next week or two.

Thanks!

actuallydan commented 6 years ago

Great, I can try to take a crack at it, but I expect you'll have a much better solution. I'll consider this closed so you can close it whenever you push the changes, or you can close it now and I'll just keep an eye out. Thanks again!

ianmiller347 commented 6 years ago

@danknotdank this is fixed here: https://github.com/ianmiller347/feather-icons-react/pull/2

published and fixed in latest feather-icons-react version 0.2.0

-- note i still was unable to make it fully automated, but I did change it around so that I use the latest generated icons JSON file from feather lib, which will help quickly do updates in future versions. Although now it is using dangerouslySetInnerHTML on sanitized input, it still seems like we can figure out a better solution. This will work for now. Still not ready to call it version 1.0 yet, but it's fully working.