search

iann0036 / AWSConsoleRecorder

Records actions made in the AWS Management Console and outputs the equivalent CLI/SDK commands and CloudFormation/Terraform templates.
MIT License
1.42k stars 87 forks source link

Invalid property "VPCOptions: VPCId" in AWS ES VPC cloudformation template #11

Closed marcosnr closed 5 years ago

marcosnr commented 5 years ago

Hi, first of all I want to congratulate you for the awesome product, it is truly amazing! While using it I just found the following small bug when recording a creation of an AWS-ES domain on cloudformation: Describe the bug template will have the invalid property 

                VPCId: "vpc-id123"   ...```

as in:

resource: Type: "AWS::Elasticsearch::Domain" Properties: (...) VPCOptions: VPCId: "vpc-ID123" SubnetIds: (...)

Related Mapping Type: "AWS::Elasticsearch::Domain"

To Reproduce follow standard procedure to create a VPC ES domain: see: https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-vpc.html

Expected behavior as described in the official documentation, this option is not valid: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticsearch-domain.html?shortFooter=true#cfn-elasticsearch-domain-vpcoptions

is not a showstopper whatsoever, just in case you have the same issue somewhere else. Thanks again for this contribution!!!

iann0036 commented 5 years ago

Cheers Marcos,

This one will be resolved in the next release, or use master. If you find others please raise as you find them.