iann0036 / AWSConsoleRecorder

Records actions made in the AWS Management Console and outputs the equivalent CLI/SDK commands and CloudFormation/Terraform templates.
MIT License
1.43k stars 86 forks source link

CFN AWS::EC2::InternetGateway mapping invalid #24

Open treaz opened 5 years ago

treaz commented 5 years ago

Describe the bug When I create a new IGW with default settings (just setting the name), there's an empty properties attribute that also gets created. CFN will reject this because "Properties 'null' values are not allowed in templates"

Related Mapping AWS::EC2::InternetGateway

Related Language CFN yml

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior The empty properties does not appear in the template.

iann0036 commented 5 years ago

Hey Horia,

Thanks heaps for raising. The fix for the empty Properties object will be in the next release, 0.3.10. There is however a slightly different issue that won't be fixed short term being that the call to add the name tag is made separately from the creation call, which I'm not currently handling yet.

Hope this helps at least get you a valid template short term.

treaz commented 5 years ago

Hey Ian, I don't see any tagging or releases on github. How will I know that the new version is out? And on the dashboard of the plugin I don't see any version mentioned. Feature request? :)

iann0036 commented 5 years ago

Hey Horia,

You'll find current versions via the store page or via your chrome://extensions page. Extensions on Chrome auto-update every 5 hours.

I'll put the version in the Settings page somewhere shortly.