iann0036 / AWSConsoleRecorder

Records actions made in the AWS Management Console and outputs the equivalent CLI/SDK commands and CloudFormation/Terraform templates.
MIT License
1.43k stars 86 forks source link

Empty Popup when pinned to Overflow Menu in Firefox #49

Closed ansgarm closed 4 years ago

ansgarm commented 4 years ago

When you pin the extension to the Overflow Window in Firefox 72 (right-click > Pin to Overflow Menu) only a white empty popup is shown. Works fine when unpinned.

Screenshot 2020-01-31 at 11 49 11

(ACR 0.3.31 in Firefox 72.0.2 on OS X 10.14.6)

iann0036 commented 4 years ago

Hi Ansgar,

Thanks for raising!

I've adjusted the popup page styling in 0.3.32 that should allow it to show in an overflow menu box. Note that I haven't adjusted it to be center-aligned to the full menu box as I'm not super familiar with it.

Let me know if the updated version helps.

ansgarm commented 4 years ago

Wow, thank you for the quick response! And the fix.
It works like a charm – even seems to be centered. But I wouldn't care if it wasn't as long as I can press the buttons 😄
Have a nice weekend!