iann0036 / former2

Generate CloudFormation / Terraform / Troposphere templates from your existing AWS resources.
https://former2.com
MIT License
2.2k stars 266 forks source link

RDSParameterGroupName not populeated in Cfn #278

Open dritz-ecloud opened 1 year ago

dritz-ecloud commented 1 year ago

In the Web GUI, RDS->Parameter Groups-> [] -> DBParameterGroupName is displayed. However, this field never makes it into the generated CloudFormation.

Possibly related, Former2 isn't replacing the RDS::DBInstance property DBParameterGroupName with the corresponding RDS::DBParameterGroup name.

This is the Parameter Group (named prod-corpsys):

RDSDBParameterGroup17:
    Type: AWS::RDS::DBParameterGroup
    Properties:
      Description: Parameter group for prod-corpsys
      Family: mysql5.6
      Parameters:
        connect_timeout: '31536000'
        delayed_insert_timeout: '31536000'
        ...

Referencing RDS Instance:

  RDSDBInstance18:
    Type: AWS::RDS::DBInstance
    Properties:
...
      DBSubnetGroupName: prod-corpsys
...

Thanks for taking a look.

iann0036 commented 1 year ago

Hey @dritz-ecloud,

Thanks for raising!

I've made a change that should hopefully allow the cross-referencing to work, however I don't see a property that would match for the name in the documentation.

If you know how this should map, feel free to let me know.

dritz-ecloud commented 1 year ago

Thanks so much!

Here are the newly updated properties:

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/pull/333/files/331411c4ad569294ebb2197cc729e4c968e6fd2a

On Nov 3, 2022, at 5:51 AM, Ian Mckay @.***> wrote:



Hey @dritz-ecloudhttps://github.com/dritz-ecloud,

Thanks for raising!

I've made a change that should hopefully allow the cross-referencing to work, however I don't see a property that would match for the name in the documentationhttps://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbparametergroup.html.

If you know how this should map, feel free to let me know.

— Reply to this email directly, view it on GitHubhttps://github.com/iann0036/former2/issues/278#issuecomment-1301858976, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXVQ4T2H32W5E3KX6OVOE2LWGODJLANCNFSM6AAAAAARVMDEUQ. You are receiving this because you were mentioned.Message ID: @.***>

iann0036 commented 1 year ago

Oh, that's new new. Thanks for letting me know.

Should be updated now.