search

iann0036 / iam-dataset

A consolidated cloud IAM dataset
MIT License
232 stars 23 forks source link

s3.UploadPart resource mapping body to BucketName #14

Closed dfangl closed 2 years ago

dfangl commented 2 years ago

Hey there! First of all - thanks for this great project.

I discovered a minor inconsistency: It seems in https://raw.githubusercontent.com/iann0036/iam-dataset/main/map.json , the resource_mappings for s3:UploadPart are wrong, since it maps the body of the sdk request to BucketName, instead of (as I assume correctly), ${Bucket} as seen in s3:UploadPartCopy for example. I also cannot see any indication in the API docs: https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html that this method should behave any differently than others.

iann0036 commented 2 years ago

Hey @dfangl,

Thanks soo much for raising! That was indeed an error and I've updated the mapping to reflect this. It'll land in downstream (permissions.cloud / iamlive) within the next day or so.

Feel free to raise any other issues you see like this.

dfangl commented 2 years ago

Thanks for the quick fix!