ianpatt / sfse

Starfield Script Extender
Other
338 stars 32 forks source link

Clarify the CMake generator needed #13

Closed avoroshilov closed 1 year ago

avoroshilov commented 1 year ago

I have multiple MSVS versions installed, and following instructions provided:

cmake -B sfse/build -S sfse
cmake --build sfse/build --config Release

didn't work, compilation failed due to numerous errors like this:

sfse/GameFormComponents.h(29,48): error C2429: language feature 'terse static assert' requires compiler flag '/std:c++17'

which indicates that it needs newer MSVS than it picked up. I checked, and the generator it picked up by default was "Visual Studio 16 2019".

So the solution is either specify the minimum C++ dialect, or just specify what generator to use in the readme, for example by clarifying the commands to be

cmake -B sfse/build -S sfse -G "Visual Studio 17 2022"
cmake --build sfse/build --config Release

This way it worked for me with multiple MSVS installed.