search

ianperrin / MMM-Formula1

A MagicMirror Module for displaying Formula 1 driver and constructor standings.
MIT License
30 stars 13 forks source link

Changed flag img to div and removed alt text #14

Closed ghost closed 7 years ago

ghost commented 7 years ago

I had borders around the flags and also the alt text showing up on the image. This fixes the issue.

ghost commented 7 years ago

@ianperrin I'm trying currently to fix minor issues and make improvements (also for myself) and the changes have become so that I can't request you to merge them anymore.

I think I'll run this as my own fork. But you can check out the changes and cherry pick of course :)

ianperrin commented 7 years ago

@anton19291 - rather than permanently changing the flags to colour, it would be better to do this as a module option e.g. grayscale which by default is true (for backwards compatibility.)

When set to true, add the grayscale class to the flag image div When false, do not add the class

Then reenabled the css under .MMM-Formula1 .flag .grayscale { ... }

ianperrin commented 7 years ago

@anton19291 - Thanks for your changes. Rather than making them defaults for everyone, I've incorporated them into two new modules options grayscale and showFooter. Keep up the good work!