search

ianperrin / MMM-NetworkScanner

A module for MagicMirror which determines the status of devices on the network based on their MAC or IP address
MIT License
107 stars 47 forks source link

Fix KeepAlive refresh #19

Closed leveneg closed 6 years ago

leveneg commented 6 years ago

The state of every device was getting reset on every network refresh, which is problematic when we want to display devices that weren't in the refresh, but haven't passed their keepalive timeout.

This change determines if a device has gone past the timeout before saving it to the devices to be displayed on the screen.

Fixes issue #14

kyle-kelly commented 6 years ago

@leveneg it looks like your master branch has commits that go beyond what you've submitted here. If your version is stable you might as well include all commits in this PR, even if they're just refactoring changes.

It seems like @ianperrin is open to having this project be maintained by the community so it makes sense that your master head becomes the module head.

leveneg commented 6 years ago

@kyle-kelly: That's correct, however I wanted to keep the scope of my PR limited to resolving this issue.

If @ianperrin is interested in having myself and others further extend this project I'd certainly be interested, though I feel it's a conversation that belongs outside of this issue.

kyle-kelly commented 6 years ago

@leveneg Understood. Just wouldn't want you to release an untested version of the module.

leveneg commented 6 years ago

@kyle-kelly: I've tested this PR on my network. Should do the trick :)

ianperrin commented 6 years ago

Thanks @leveneg and @kyle-kelly - pull request merged