search

ianperrin / MMM-NetworkScanner

A module for MagicMirror which determines the status of devices on the network based on their MAC or IP address
MIT License
107 stars 47 forks source link

Suspend/resume scanning when the module is hidden/shown #22

Open wi-brewer opened 6 years ago

wi-brewer commented 6 years ago

Hi, sorry this is not a bug.

I think it would be cool if you could specify that we only scan for occupants during a specific time range. For example I don't want or need it to scan if I am on the network while I'm sleeping.

E3V3A commented 6 years ago

@wi-brewer If you don't need to scan you can always enable/disable the module with a cron job. (There is another module that make this easy for you, but I forgot which one.) So I don't see the need to add that functionality into the module.

ianperrin commented 6 years ago

@E3V3A - would that be MMM-ModuleScheduler by any chance? :)

ianperrin commented 6 years ago

@wi-brewer - if you want to hide the module at certain times, you can do so with MMM-ModuleScheduler

An enhancement to MMM-NetworkScanner would be to suspend the scanning activity whilst the module was hidden and resume again when it is shown again.

Additionally, adding support for suspending scanning if a resident is not online is another enhancement for consideration