search

ianperrin / MMM-NetworkScanner

A module for MagicMirror which determines the status of devices on the network based on their MAC or IP address
MIT License
107 stars 47 forks source link

columns are misaligned depending on module positions top_right or top_left #30

Closed E3V3A closed 6 years ago

E3V3A commented 6 years ago

The columns are misaligned depending if the module position is on left or right side (e.g. top_right or top_left). Ideally there should be a CSS left justification somewhere in the DOM. (And right just for 3rd and last column.)

Also need column space when last seen not enabled/available. Related to #29

E3V3A commented 6 years ago

The best solution is probably to add a CSS file, and make sure we have 3 columns.

ianperrin commented 6 years ago

@E3V3A - 1a89250 (on the develop branch) contains an initial fix for the alignment issues. Could you test and confirm it works as expected?

cd ~/MagicMirror/modules/MMM-NetworkScanner
git checkout --track origin/develop
E3V3A commented 6 years ago

Great! Yeah, that seem to work! :+1:

ianperrin commented 6 years ago

Thanks @E3V3A - v0.0.4 has been published - you may want to switch back to the master branch again:

cd ~/MagicMirror/modules/MMM-NetworkScanner
git checkout master