Develop - Added showChannelThumbnail config option

[codecov-commenter]

Codecov Report

Merging #2 (a8f9907) into develop (57a4c4a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop       #2   +/-   ##
========================================
  Coverage    90.62%   90.62%           
========================================
  Files            1        1           
  Lines           64       64           
========================================
  Hits            58       58           
  Misses           6        6           

Impacted Files	Coverage Δ
MMM-YouTubeChannelStats.js	90.62% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57a4c4a...a8f9907. Read the comment docs.

[jbishop129]

Hi @ianperrin I’m not a real developer :) So I don’t really understand what is happening here, or if I should be doing something different due to this failure

[ianperrin]

@jbishop129 - don't worry, it can all look a bit overwhelming!

When a change is committed or pull request is submitted to this repository, a series of checks are performed.

1. The first set of checks are prefixed with the label Tests / test (...). They test that

   • the code works as expected in different versions of NodeJS . As an example, there is a function called toMetric in the code. It is expected to return 12.3K if the value passed to it (e.g. number of subscribers) is 12345. The tests confirm that any change to the code haven't adversely affected this.
   • the code is formatted in a consistent style using prettier.io

2. The second set of checks determine whether the coverage of the tests has been impacted by the change. For example, the commit may have added new functions or code which is not included in a test. This check would highlight that.

In this instance, the coverage check passed successfully as did the check to ensure the code works as expected. However, the formatting check failed.

So what happens next?

One option is that you can attempt to fix the issue. To do this, you would need to perform the follow steps in your version of the code

cd ~/MagicMirror/modules/MMM-YouTubeChannelStats
npm install
npm run lint:prettier

Once you have done this, review and commit the formatting changes. This will in turn update the pull request

Alternatively, and well done for getting this far, I can fix this for you when I review the changes.

Let me know which you prefer.

[jbishop129]

Thanks for explaining, this is helpful, and way over my crappy code-writing skills! As far as resolving the code fix, I’ll probably have to pass it to you, because I didn’t fork and commit this properly: I did this code edit manually in my own MagicMirror, when I got it working the way I wanted, I went to your repo, forked it, and manually did those edits to match what I did locally, then committed it. I got away with this because the changes were literally 3 lines of code, but I know you’re cringing as a developer!

Joe

On May 5, 2021, at 8:30 AM, Ian @.***> wrote:

 @jbishop129 - don't worry, it can all look a bit overwhelming!

When a change is committed or pull request is submitted to this repository, a series of checks are performed.

The first set of checks are prefixed with the label Tests / test (...). They test the code

works as expected in different versions of NodeJS . As an example, there is a function called toMetric in the code. It is expected to return 12.3K if the value passed to it (e.g. number of subscribers) is 12345. The tests confirm that any change to the code haven't adversely affected this. is formatted in a consistent style using prettier.io The second set of checks determine whether the coverage of the tests has been impacted by the change. For example, the commit may have added new functions or code which is not included in a test. This check would highlight that.

In this instance, the coverage check passed successfully as did the check to ensure the code works as expected. However, the formatting check failed.

So what happens next?

One option is that you can attempt to fix the issue. To do this, you would need to perform the follow steps in your version of the code

cd ~/MagicMirror/modules/MMM-YouTubeChannelStats npm install npm run lint:prettier Once you have done this, review and commit the formatting changes. This will in turn update the pull request

Alternatively, and well done for getting this far, I can fix this for you when I review the changes.

Let me know which you prefer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.