ianpittwood / Gerrit-to-Github-Issues

Set of scripts that can be used to synchronize/update Github Issues with data from a Gerrit instance
Apache License 2.0
2 stars 2 forks source link

Reference Patchsets need to manage ready for review label properly. #10

Open jezogwza opened 3 years ago

ian-howell commented 3 years ago

Adding some context.

When a commit which has the "Relates-To" tag is created, the bot will add the "ready for review" label to the related issue. However when the commit is merged, the bot doesn't remove the label. This causes a problem when a GH issue requires multiple commits to close, since the first commit marks it as "ready to review", and merging that commit doesn't remove the label, leaving the issue labeled "ready to review" with no changes to review.

A solution might involve checking whether there are any "Relates-To" or "Closes" commits that are not closed, and if so, label the issue. Otherwise, verify that the issue is not labeled.