search

ianramzy / decentralized-video-chat

🚀 Zipcall- Acquired @ 250k users 🚀 Peer to peer browser video calling platform with unmatched video quality and latency.
https://zipcall.io
3.31k stars 502 forks source link

Window reloads every time a connection is established #13

Open Chaphasilor opened 4 years ago

Chaphasilor commented 4 years ago

When the second user connects, the first user's window will reload first. This resets any settings and therefore could be abused.

During a call, if one peer disables audio or video, the other peer could simply reload the page and re-join the call in order to trigger a reload for the first peer, causing the first peer to send audio and video again.

sladyn98 commented 4 years ago

Any way to rectify this, would love to contribute :)

Chaphasilor commented 4 years ago

Sure, start by forking the repo and setting it up locally, following the instructions in the readme. After that, you can tinker with the code and try to fix the issue (probably located in chat.js).

If you manage to fix this, feel free to open a pull request (after running npx prettier --write . and if everything works it will be merged :)