search

ianrenton / SuccessWhale

:whale: A web-based multi-column social network client. No longer functional or maintained!
BSD 2-Clause "Simplified" License
14 stars 7 forks source link

New style RTs appear as old style. #17

Closed SiliconMeeple closed 13 years ago

SiliconMeeple commented 13 years ago

This still truncates the tweet at 140 characters, so the witty message and/or link get clipped and the interested user has to track down the original message on the users twitter.com timeline.

Could be solved either by displaying the tweet "new RT style", or not truncating them (if this is done on SWs end).

ianrenton commented 13 years ago

Truncation isn't done at SW's end, so we'd have to switch to showing new-style RTs. I take it everyone's in favour of that anyway? (I don't see RTs, so I don't mind one way or the other.)

SiliconMeeple commented 13 years ago

I certainly would be.

Had a look at the code / twitter API yesterday and got a bit confused as none of the examples I could find included a retweet, or want to mention the "retweeted_status" field.

It all makes perfect sense now. Might send a patch later. :)

ianrenton commented 13 years ago

RTs are now still shown old-style, but use the full text from retweeted_status.

SiliconMeeple commented 13 years ago

Is this live?

ianrenton commented 13 years ago

Only on the test server.

ianrenton commented 13 years ago

Now showing new-style RTs with retweeter info on hover.